Lock the version of the spawned server #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts about writing a test for this? It's a little tricky to add a regression test, because the bug only manifests when you're running an older version of the gem than the most recent version installed. |
|
Is there any interest in this change from the maintainers? I'm happy to rebase the branch and fix the merge conflicts if so. |
|
Hi @TimMoore, sorry for the slowness. This change looks good to me. Please do rebase and I'll get it released. |
This fixes a bug when the currently-executing version of Spring is not the most recent version available in the gem path. Previously, this would launch the most recent server version and cause an error when Bundler detects the mismatch. Fixes #295.
|
Thanks, @jonleighton. Done! |
jonleighton
added a commit
that referenced
this pull request
May 8, 2015
Lock the version of the spawned server
NuckChorris
added a commit
to hummingbird-me/kitsu-tools
that referenced
this pull request
Jun 6, 2015
NuckChorris
added a commit
to hummingbird-me/kitsu-tools
that referenced
this pull request
Jun 6, 2015
NuckChorris
added a commit
to hummingbird-me/kitsu-tools
that referenced
this pull request
Jun 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when the currently-executing version of Spring is not the most recent version available in the gem path. Previously, this would launch the most recent server version and cause an error when Bundler detects the mismatch.
Fixes #295.